Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support verification of download and install size #168

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

MrHadiSatrio
Copy link
Contributor

What has changed

Ruler now supports verification of AAB download and install sizes against user-defined thresholds. This new feature allows developers to ensure their app bundles meet size requirements before deployment.
Example configuration:

ruler {
    // Other configurations...
    verification {
        downloadSizeThreshold = 2 * 1024 * 1024 // 2 MB in bytes
        installSizeThreshold = 2 * 1024 * 1024 // 2 MB in bytes
    }
}

If the AAB exceeds either threshold during the analyze<Variant>Bundle task, Ruler will throw a VerificationException:

Execution failed for task ':sample:app:analyzeDebugBundle'.
> com.spotify.ruler.common.verification.VerificationException: Download size exceeds the threshold by 1107079 bytes.

Why was it changed

If an end user requires such functionality, they would currently have to either implement a processor for Ruler's output files or depend on other tools (e.g., apkanalyzer). Having this built into Ruler would help centralize that logic, thus reducing potential duplication.

Copy link
Collaborator

@ViktorPetrovski ViktorPetrovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MrHadiSatrio
Copy link
Contributor Author

Thanks for the review, @ViktorPetrovski.

Unfortunately, CI seems to fail with a reason unrelated to this changeset. I made an attempt to fix that through #169.

@MrHadiSatrio MrHadiSatrio deleted the verification branch September 23, 2024 15:50
@MrHadiSatrio MrHadiSatrio restored the verification branch September 23, 2024 15:50
@MrHadiSatrio
Copy link
Contributor Author

Accidentally deleted this branch on my fork, my bad. Reopening the PR.

@MrHadiSatrio MrHadiSatrio reopened this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants