-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support verification of download and install size #168
Open
MrHadiSatrio
wants to merge
4
commits into
spotify:main
Choose a base branch
from
MrHadiSatrio:verification
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruler-common/src/main/java/com/spotify/ruler/common/veritication/VerificationException.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
MrHadiSatrio
force-pushed
the
verification
branch
from
September 18, 2024 15:33
6fd2859
to
56b0454
Compare
Thanks for the review, @ViktorPetrovski. Unfortunately, CI seems to fail with a reason unrelated to this changeset. I made an attempt to fix that through #169. |
Accidentally deleted this branch on my fork, my bad. Reopening the PR. |
ViktorPetrovski
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed
Ruler now supports verification of AAB download and install sizes against user-defined thresholds. This new feature allows developers to ensure their app bundles meet size requirements before deployment.
Example configuration:
If the AAB exceeds either threshold during the
analyze<Variant>Bundle
task, Ruler will throw aVerificationException
:Why was it changed
If an end user requires such functionality, they would currently have to either implement a processor for Ruler's output files or depend on other tools (e.g.,
apkanalyzer
). Having this built into Ruler would help centralize that logic, thus reducing potential duplication.